Added parsing of param property value_choices. #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcserrat
approved these changes
Jun 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 91.09% 91.24% +0.15%
==========================================
Files 31 31
Lines 1415 1417 +2
==========================================
+ Hits 1289 1293 +4
+ Misses 126 124 -2
Continue to review full report at Codecov.
|
vgrebenschikov
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parsing of param property value_choices. I could not find this property on the Connect API docs, perhaps it should be updated?
There is a similar value_choice in the docs, but it contains a list of strings, while this contains a list of objects with "label" and "value" fields.